cuda.core: expose last prefetch location on ManagedBuffer - #2774
Merged
Conversation
Contributor
isVoid
marked this pull request as ready for review
September 8, 2026 17:49
Contributor
Author
|
/ok to test |
Contributor
@isVoid, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
Contributor
Author
|
/ok to test 08b4cf4 |
| from cuda.core._utils.version import binding_version, driver_version | ||
|
|
||
| if binding_version() < (13, 0, 0) or driver_version() < (13, 0, 0): | ||
| pytest.skip("Host NUMA last-prefetch location requires CUDA 13") |
Contributor
There was a problem hiding this comment.
I've been trained to lean towards skipping at collection time. Worth doing here?
Contributor
Author
There was a problem hiding this comment.
Not sure if there are any order requirement at test collecting time and initializing CUDA. Let me check with my agent to see if possible.
brandon-b-miller
requested changes
Sep 9, 2026
brandon-b-miller
left a comment
brandon-b-miller
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good. Based on what happened when this features sibling attrs were introduced, I infer that we may need a release notes entry documenting this new feature.
Contributor
Author
|
/ok to test afb0334 |
Contributor
Author
|
/ok to test bcf63da |
This comment has been minimized.
This comment has been minimized.
brandon-b-miller
approved these changes
Sep 11, 2026
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #2109
Expose the read-only
ManagedBuffer.last_prefetch_locationproperty.Device,Host, orNone.LAST_PREFETCH_LOCATION_TYPE/_IDpair so NUMA host locations round-trip.Testing
cd cuda_core && pixi run -e cu13 pytest tests/memory/test_managed_ops.py -q— 37 passed, 1 skippedcd cuda_core && pixi run -e cu12 pytest tests/memory/test_managed_ops.py -q— 16 passed, 22 skippedChecklist